feat: implement admin-only oracle consensus threshold update (#75)#172
Closed
GoodnessJohn wants to merge 12 commits intoNetwalls:mainfrom
Closed
feat: implement admin-only oracle consensus threshold update (#75)#172GoodnessJohn wants to merge 12 commits intoNetwalls:mainfrom
GoodnessJohn wants to merge 12 commits intoNetwalls:mainfrom
Conversation
…s#75) - Add set_consensus_threshold function with strict admin access control - Validate threshold >= 1 and <= oracle_count - Emit ThresholdUpdatedEvent with previous/new values and timestamp - Add 10 comprehensive unit tests covering: - Successful updates and boundary values - Unauthorized access attempts - Invalid threshold rejection (zero, exceeding count) - Event emission verification - Multiple updates and integration scenarios - Maintain deterministic execution and storage integrity - Include complete documentation and validation scripts Closes Netwalls#75
- Replace env.register(Contract, ()) with env.register_contract(None, Contract) - Fix setup_oracle helper in oracle.rs tests - Fix all contract registrations in oracle_test.rs - Resolves compilation errors with latest Soroban SDK
- Fix multi-line assert! formatting - Fix method chaining indentation - Fix blank line spacing - Resolves cargo fmt check failures
- Add IntoVal import for MockAuth args conversion - Add Events import for env.events().all() method - Resolves compilation errors in test module
…d remove needless borrows
…nd contracttype import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75